Repository navigation
@hanzo/build 0.2.130: on a phone the views take a row of their own, so Code is in reach - #34
Merged
Merged
Conversation
…o Code is in reach At 375 wide beside a project named "Instrument" the workspace bar left its middle 49px: the view tabs scrolled inside it, part of Chat in sight and Preview, Files and Code past the edge. Below md the views (with Chat) now sit in a row under the bar, in whichever pane shows; md and up are unchanged. Part of hanzo-inc/app#305 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of hanzo-inc/app#305
What was wrong
On hanzo.app/dev, a template taken into a project now opens with working Preview, Files and Code at desktop width (checked live on a fresh copy of Instrument: Files lists the tree,
index.htmlopens in Code). At phone width it doesn't work. At 375 px, beside a project named "Instrument", the workspace bar's start cluster (mark, project chip, History) took 246 px and left the middle, where the view tabs live, 49 px. The tabs scrolled inside that strip: part of Chat was visible, and Preview, Files and Code were past the edge with no hint they were there.Change
project.tsx: belowmdthe views (with the phone's Chat entry) leave the bar and get a row of their own under it, in whichever pane is showing.mdand up are unchanged.Testing
pnpm typecheck,pnpm test(868 passed),pnpm build.cov-forge-project.spec.tstest at 360, 375 and 390 with a long project name: all five view tabs are whole on screen and not covered, Publish shows, the page doesn't scroll sideways, and Files →index.htmlopens in Code. Against main it fails with "Chat ends on screen: 388 > 375".screens.spec.tsproject states at phone, tablet, laptop and desktop (25 passed).