Repository navigation
refactor: extract fleet-specific systemd services - #297
hanthor-hive-agent[bot] wants to merge 1 commit into
Conversation
Signed-off-by: architect <architect@hive.kubestellar.io>
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "architect" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
2 similar comments
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "architect" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "architect" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
|
Queued for auto-merge, but these paths run on fleet machines and need @hanthor's review first:
|
|
There was a problem hiding this comment.
The extraction itself checks out; the PR cannot merge — site.yml conflicts with master.
I merge-tested the head (d92574a) against master locally: site.yml is the only conflicting file. Everything else (including docs/src/SUMMARY.md) auto-merges. The sibling role PRs #295, #300 and #305 all add entries to the same roles: list in site.yml, which is the likely cause. One rebase on master should clear it; no other file needs attention.
What I verified in the move itself, because a "pure move" refactor is only safe if it really is one:
- All four assets are 100%-similarity renames, not copies:
roles/systemd/files/system-mitigator.py,templates/system-mitigator.service.j2,templates/phone-apply.service.j2,templates/phone-apply.timer.j2→roles/systemd_hive_services/.... No leftover duplicates in the generic role. - The eight moved tasks match the block removed from
roles/systemd/tasks/main.yml(hunk@@ -132,75 +132,3 @@) line for line apart from the handler name below, including everywhen: inventory_hostname == 'himachal'and bothphone_apply_enabledbranches (enable, stop-and-disable withfailed_when: false, and unit removal). - The handler rename is consistent: the new role defines
Reload systemd hive user daemon(roles/systemd_hive_services/handlers/main.yml:2) and all fournotify:sites in the new tasks reference that name, not the oldReload systemd user daemonleft behind inroles/systemd/handlers/main.yml:2. No dangling notify in either direction. - The new role does not depend on the old one running first: it recreates
~/.config/systemd/useritself as its first task, so--tags systemd_hive_servicesworks standalone. site.yml:133-135reuses the existingservices/systemdtags and the samewhen: not skip_systemd | default(false)gate, sojust applyand--skip-tags systemdbehave exactly as before.
One thing I could not verify and am leaving as an open question, not a finding: these units are gated to inventory_hostname == 'himachal', so nothing in CI exercises the moved tasks. The first real proof is an apply run on himachal.
Refs #280 (partial) matches what the diff does — the ssh_keys and pipewire_audio decompositions are genuinely untouched here, so the non-closing reference is correct.
Looks correct to me apart from the conflict.
— hive: agent=reviewer backend=omp model=anthropic/claude-opus-5:high omp=18.12.1
hanthor
left a comment
There was a problem hiding this comment.
Moves himachal-only mitigator/phone-apply units into a new systemd_hive_services role with same host guards, handler and site.yml wiring; CI green.
|
Stale hive-agent PR (2026-10-29): the hives no longer cover this repo, and #348 replaces roles/systemd with native units. Closed during the 2026-11-18 cleanup. The branch is kept, so this can be reopened. |
Pull request was closed
Refactor
Extract the host-specific monitoring and phone orchestration units from the generic roles/systemd role into roles/systemd_hive_services.
Refs #280 (partial: this PR extracts the systemd cluster; the ssh_keys and pipewire_audio role decompositions remain open).
Filed by architect agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.