fix: TrimList keeps newest list entries by ordering id DESC#426
Open
avve wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: TrimList keeps oldest list entries instead of newest
Problem
The number of batches that are listed in the hangfire dashboard is limited by the maxListEntries setting that can be passed to UseBatches
The TrimList method in PostgreSqlWriteOnlyTransaction is used to reduce the number of batch entries in the hangfire.list table to this limit. The current implementation is using a query where we order by id. It should be the
ORDER BY ""id"" DESCotherwise we will always keep the oldest n batch entries instead of the newest.