-
Notifications
You must be signed in to change notification settings - Fork 156
HF-85: Implement all database functions #1652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcin-kordas-hoc
wants to merge
23
commits into
develop
Choose a base branch
from
feature/HF-85-implement-function-dcount
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8d5373a
Docs: add basic usage snippets to framework integration guides
marcin-kordas-hoc f919dd3
Implement DCOUNT database function
marcin-kordas-hoc 424f13f
ci: retrigger
marcin-kordas-hoc 086aa08
ci: retrigger after tests PR created
marcin-kordas-hoc 26434dc
Implement DSUM, DCOUNTA, DPRODUCT database functions
marcin-kordas-hoc 22c3433
fixup! Implement DAVERAGE, DMAX, DMIN, DGET database functions
marcin-kordas-hoc 7efebc8
Implement DSTDEV, DSTDEVP, DVAR, DVARP database functions
marcin-kordas-hoc 2d7025e
Implement all 12 database functions (D-functions family)
marcin-kordas-hoc 948132a
fix: remove unnecessary type assertions in DatabasePlugin (lint)
marcin-kordas-hoc 18906bc
Docs: add Database section to built-in-functions.md and nuances to kn…
marcin-kordas-hoc 0dc18ad
refactor: extract shared boilerplate in DatabasePlugin (DRY)
marcin-kordas-hoc 6a14594
fix: remove Excel mention from known-limitations, trailing space
marcin-kordas-hoc f7d91fc
ci: retrigger after tests repo rebase
marcin-kordas-hoc 594c9a2
fix: Czech DCOUNT translation and boolean field coercion
marcin-kordas-hoc 11b0488
fix: guard resolveFieldIndex against non-finite indices
marcin-kordas-hoc 3b238de
fix: propagate CellError from field and criteria arguments
marcin-kordas-hoc 0099900
fix: Dutch DCOUNTA translation typo (DBAAANTALC -> DBAANTALC)
marcin-kordas-hoc 11cf389
fix: Norwegian DCOUNT translation (ANTALLDB -> DANTALL)
marcin-kordas-hoc 947a9fd
fix: propagate CellError from field cells in D-function aggregations
marcin-kordas-hoc 2727f8e
fix: propagate CellError from field cells in DCOUNT and DCOUNTA too
marcin-kordas-hoc 4e73545
fix: Polish diacritics + DGET CellError explicit guard
marcin-kordas-hoc 42d5e09
fix: correct D-function translations for cs, tr, da, pt per Microsoft…
marcin-kordas-hoc 9d07107
fix: DGET multiple-match check takes priority over field CellError
marcin-kordas-hoc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,3 +38,5 @@ you can't compare the arguments in a formula like this: | |
| * The INDEX function doesn't support returning whole rows or columns of the source range – it always returns the contents of a single cell. | ||
| * The FILTER function accepts either single rows of equal width or single columns of equal height. In other words, all arrays passed to the FILTER function must have equal dimensions, and at least one of those dimensions must be 1. | ||
| * Array-producing functions (e.g., SEQUENCE, FILTER) require their output dimensions to be determinable at parse time. Passing cell references or formulas as dimension arguments (e.g., `=SEQUENCE(A1)`) results in a `#VALUE!` error, because the output size cannot be resolved before evaluation. | ||
| * DGET returns `#VALUE!` when no records match the criteria, and `#NUM!` when more than one record matches. | ||
| * DMAX, DMIN, and DPRODUCT return `0` when no records match the criteria. | ||
|
Comment on lines
+41
to
+42
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is it listed as limitations? Is it different to what Excel does? |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The framework integration guides should not be modified in this PR