Repository navigation
don't sync selection when the document loses browsing context - #286
Merged
Merged
Conversation
smoores-dev
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some clients are reporting occasional errors when extending the dom selection in
setSelectiondue toview.root.getSelection()returning null. That happens when the document has no browsing context.This updates useEditor to avoid committing pending effects if there's no browsing context so that we don't run into the
setSelectionerror. It also adds a check that getSelection doesn't return null before explicitly callingsetSelectionin the one other place we do that.