Revert "Improve partial indenting performance"#2042
Open
mohd-akram wants to merge 1 commit intohandlebars-lang:4.xfrom
Open
Revert "Improve partial indenting performance"#2042mohd-akram wants to merge 1 commit intohandlebars-lang:4.xfrom
mohd-akram wants to merge 1 commit intohandlebars-lang:4.xfrom
Conversation
This reverts commit 08fddee. The change caused performance regressions in some cases and performance was not consistent across engines.
Member
|
Note to myself: also revert this in |
Contributor
Author
|
@jaylinski Any update on merging/releasing this and #2041? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 08fddee.
The change caused performance regressions in some cases and performance was not consistent across engines.