Draft: Generate s3 file listing after each upload#1980
Conversation
nknapp
force-pushed
the
generate-s3-file-listing
branch
from
c82ff72 to
ab920cc
Compare
|
@jaylinski if you like, you can have a look at this already. If have extracted the s3-logic to grunt-independent functions and added an s3-listing function. With this, we should be able to generate some kind of listing-file, be it json, or, using Handlebars, directly a static html. |
|
@jaylinski I have manually generated and deployed a static file-list to the s3-bucket using the code from this PR. This means we have a file-list now, but it will be outdated on the next build. I have also fixed the link from the docs to the file-list. The HTML file-list is generated via Handlebars, but the template and the JavaScript inside (fileList.hbs) is rather hacky. (i.e. no tests or so). The tests for the generation and upload-code must be run manually. I think this is better than before (where there were no tests at all), but maybe we should use "mocha" or so. I don't think we should run these tests on every build. With the deployed "index.json" file, we can integrate the file-list directly into the docs. Please have a look and let me know what you think. |
| @@ -0,0 +1,127 @@ | |||
| <!doctype html> | |||
There was a problem hiding this comment.
Maybe activate prettier formatting for this file?
There was a problem hiding this comment.
Did you update all deps? Seems to have lots of changes...
2 participants
This PR is not ready yet. I am currently playing with the S3 api.
In order to fix the builds page we should statically generate a file-index on each upload, so that we do not have to rely on the s3-api being available from the browser.
Since we are also relying on an old version of the aws-sdk, this will probably also include an update to the newest version.