test: cover access control to prototype methods/properties on nested objects (#1858)#1859
Draft
vassudanagunta wants to merge 1 commit intohandlebars-lang:4.xfrom
Draft
test: cover access control to prototype methods/properties on nested objects (#1858)#1859vassudanagunta wants to merge 1 commit intohandlebars-lang:4.xfrom
vassudanagunta wants to merge 1 commit intohandlebars-lang:4.xfrom
Conversation
vassudanagunta
commented
May 9, 2022
vassudanagunta
commented
- per issue allowProtoMethods/Properties runtime options do not work for nested objects #1858
- adds cases for nested input objects to existing cases
- very minor refactor to re-use the same test logic, keep tests readable.
jaylinski
requested changes
May 9, 2022
Member
jaylinski
left a comment
jaylinski
left a comment
There was a problem hiding this comment.
Can you rebase your changes on the 4.x branch? Or target it on master.
…objects (handlebars-lang#1858) - per issue handlebars-lang#1858 - adds cases for nested input objects to existing cases - very minor refactor to re-use the same test logic, keep tests readable.
vassudanagunta
force-pushed
the
issue-1858-tests
branch
from
e5d3e96 to
3c16973
Compare
Author
|
Done. Sorry about that. I was following instructions to submit against 4.x but failed to realize the obvious, that I should rebase on 4.x first. Was wondering why so many commits showed up in the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.