Skip to content

[bugfix] Don't emit parts: [undefined] for {{this}}#6

Merged
pzuraq merged 1 commit intohandlebars-lang:masterfrom
dfreeman:this-path-extra-element
Jul 29, 2021
Merged

[bugfix] Don't emit parts: [undefined] for {{this}}#6
pzuraq merged 1 commit intohandlebars-lang:masterfrom
dfreeman:this-path-extra-element

Conversation

@dfreeman
Copy link
Contributor

In v2.0 and prior of the parser, parsing {{this}} would produce an AST node like this:

{
  type: 'PathExpression',
  parts: [],
  original: 'this',
  // ...
}

However, starting with v2.1, it now emits:

{
  type: 'PathExpression',
  parts: [undefined],
  original: 'this',
  // ...
}

@pzuraq pzuraq merged commit 163b275 into handlebars-lang:master Jul 29, 2021
@pzuraq
Copy link
Contributor

pzuraq commented Jul 29, 2021

Thank you!

@github-actions github-actions bot mentioned this pull request Mar 19, 2025
@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants