Feature/protostar ivc#25
Open
amit0365 wants to merge 14 commits into
Open
Conversation
han0110
reviewed
Sep 19, 2023
Comment on lines
+217
to
+219
| let powers_of_zeta_first_poly = powers_of_zeta_poly((l_sqrt-1).ilog2() as usize, zeta); | ||
| let powers_of_zeta_second_poly = powers_of_zeta_poly((l_sqrt-1).ilog2() as usize, zeta.pow(&[l_sqrt as u64])); | ||
| let powers_of_zeta_poly = powers_of_zeta_first_poly.add(&powers_of_zeta_second_poly); |
Owner
There was a problem hiding this comment.
I think this should be concatenated instead of added
Comment on lines
+354
to
+359
| let zeta_cross_term_poly = evaluate_zeta_cross_term_poly( | ||
| l_sqrt * l_sqrt, | ||
| *num_alpha_primes, | ||
| accumulator, | ||
| incoming, | ||
| ); |
Owner
There was a problem hiding this comment.
Since the constraint for zeta becomes different, I think we need another function for it
Author
There was a problem hiding this comment.
done. i m not sure about the boundary conditions on the cross terms when we deal with zeta_power_lsqrt
Comment on lines
+300
to
+309
| let powers_of_zeta_sqrt1_constraint = powers_of_zeta_constraint(zeta, powers_of_zeta_sqrt); | ||
| let zeta_sqrt1_products = products(&poly_set.preprocess, &powers_of_zeta_sqrt1_constraint); | ||
|
|
||
| let powers_of_zeta_sqrt2_constraint = powers_of_zeta_constraint(zeta.pow(l_sqrt as u32), powers_of_zeta_sqrt); | ||
| let zeta_sqrt2_products = products(&poly_set.preprocess, &powers_of_zeta_sqrt2_constraint); | ||
|
|
||
| let zeta_products = iter::empty() | ||
| .chain(zeta_sqrt1_products.iter().cloned()) | ||
| .chain(zeta_sqrt2_products.iter().cloned()) | ||
| .collect_vec(); |
Owner
There was a problem hiding this comment.
We'd need another poly and challenge by zeta_to_l and adopt the same constraint on them.
Author
There was a problem hiding this comment.
will this another poly help to recompute all the powers of beta from the square root terms? what is this challenge zeta_to_l?
amit0365
force-pushed
the
feature/protostar-ivc
branch
from
3bef759 to
ce7d71d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
review1 sqrt CV