add payment tests - #5
Merged
Merged
Conversation
AbRahman-ra
reviewed
May 13, 2026
Collaborator
There was a problem hiding this comment.
Instead of
$paymentId = (getenv('REAL_TESTS') === 'true')
? getenv('MOYASAR_SAMPLE_AUTHORIZED_PAYMENT_ID') ?: $payment->id
: $payment->id;Do 2 things:
- Include all new environment variables in
phpunit.xml.distas well as '.env.example' and '.env' with their default values, so you don't have to worry about their nullity - Since you have a default value, and in case of Mock tests you are [intuitively] mocking the response, it's safe to change the above snippet into
$invoice = getenv('MOYASAR_SAMPLE_AUTHORIZED_PAYMENT_ID') ?: $payment->id;Also, I observe in my machine that sometimes the getenv() function cast the values, that's why I wrote in tests/Config/MoyasarInitializer.php the condition like this
$isMock = empty(getenv('REAL_TESTS')) || getenv('REAL_TESTS') === 'false';It casted the value false to an empty string (false). Kindly keep that in mind for next tests
Collaborator
|
Generally LGTM |
AbRahman-ra
reviewed
May 13, 2026
| $moyasar = MoyasarInitializer::getInstance()->getMoyasar(); | ||
|
|
||
| $payment = $moyasar->payment()->create(CreatePaymentDTO::fromArray(mockCreatePaymentDTO())); | ||
| $paymentId = (getenv('REAL_TESTS') === 'true') |
Collaborator
There was a problem hiding this comment.
Same thing as the note above
AbRahman-ra
reviewed
May 13, 2026
|
|
||
| $payment = $moyasar->payment()->create(CreatePaymentDTO::fromArray(mockCreatePaymentDTO())); | ||
|
|
||
| $paymentId = (getenv('REAL_TESTS') === 'true') |
Collaborator
There was a problem hiding this comment.
same as the note above
AbRahman-ra
reviewed
May 13, 2026
|
|
||
| $payment = $moyasar->payment()->create(CreatePaymentDTO::fromArray(mockCreatePaymentDTO())); | ||
|
|
||
| $paymentId = (getenv('REAL_TESTS') === 'true') |
Collaborator
There was a problem hiding this comment.
same as the note above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.