Skip to content

add cidr2ips method#16

Open
mingoooo wants to merge 1 commit into
hamishforbes:masterfrom
mingoooo:cidr2ips
Open

add cidr2ips method#16
mingoooo wants to merge 1 commit into
hamishforbes:masterfrom
mingoooo:cidr2ips

Conversation

@mingoooo

Copy link
Copy Markdown

I have a requirement, cidr convert to a list of ip address.This is my code, maybe someone needs it.

@hamishforbes

Copy link
Copy Markdown
Owner

Cool, that seems useful!

The only thing I would say is if the cidr doesn't parse we should probably return the error rather than logging it unconditionally.
The only place we log rather than return is when parsing multiple cidrs, this is so the other potentially valid cidrs are still returned.

A couple basic tests would be good too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants