Repository navigation
Conversation
An open question in a conversation refused bloks quiet for every later turn there, so a turn nobody waits on had to reply just because an older question was still on screen. Each open request now records the lane turn it was asked in, and each lane the turn its current work began in. A quiet finish passes only a question asked before that work began; an approval, a question of the turn's own work, or a request whose turn is not known still refuses. A retry, the backup or a pickup may go on with work older than the conversation's latest turn, so it records no start, and every open request still holds it. The earlier question stays open, waiting and answerable, and a quiet finish that passed one gives back the unread dot the turn took on starting, unless the person opened the conversation meanwhile.
Owner
|
Thanks, Roman. Narrowing the open-question check to the turn's own work is the right call, and it holds wherever the start of the work isn't known. Giving the unread dot back was a nice catch too. It's landed as you wrote it, with you as author. It's in 3.2.8, out now. Closing as merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A question an agent asked without waiting stays open for as long as the person likes. Until now, any open question in a conversation refused
bloks quietfor every later turn there, so a later turn nobody waits on (another agent'sbloks say, a service wake) had to answer with a full reply just because an older question was still on screen. The person then got a reply and a notification about nothing, while the question itself was already waiting for them.This narrows the open-question guard to the turn's own work:
askedIn) and whether it only asks. A request asked again is the later turn's.workSince), set only by new work. A retry, the backup or a pickup may go on with work older than the lane's latest turn (an incident can be tried again after other turns), so it records none, and every open request still holds it.heldByRequestlets a quiet finish pass only a question asked before that work began. An approval, a question of the turn's own work, a request nobody knows the turn of, or any open request in a retry, the backup or a pickup still refuses withopen_request. The same check runs at acceptance and when the turn ends, so a question asked after acceptance still cancels the finish.Everything else is unchanged: the person's words in or on their way into the turn, shown output, rooms, check-in rules, refusal wording, the CLI and notification paths. There is no new setting, route or permission.
Tests:
test/quiet-finish-unit.test.ts: which open requests hold a quiet finish.test/codex-async-questions.test.ts: an earlier async question plus another agent's turn. The turn finishes quietly, the conversation still waits and keeps its unread dot, and the card stays open. A question of the turn's own and the person's own turn still refuse. Opening the conversation during the turn leaves no dot. Answering the question afterwards still reaches the agent. A retry after a failed try that asked, and a failed turn tried again from its incident after other work in between, still refuse withopen_request.docs/ARCHITECTURE.md, thebloks quietparagraph.