Repository navigation
scripts : log instead of print in gather_required_libs.py - #114
Merged
Merged
Conversation
The Lint job (flake8-no-print, NP100) fails on master since #112 added this script with print() calls. Use the logging module like the other scripts. Assisted-by: Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gaetan-puleo
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Lint(flake8 withflake8-no-print, rule NP100) fails on master since #112 addedscripts/rocm-release/gather_required_libs.pywith threeprint()calls. This switches them to theloggingmodule, likescripts/compare-logprobs.pyandscripts/server-bench.py. Output is unchanged, since the format is%(message)sat INFO.Measurements
Not applicable: a lint fix in a helper script that CI never runs.
Correctness:
flake84.0.1 withflake8-no-printon the file passes locally (rc 0), and the file parses.Requirements
Comment generated via automated review of clanker Claude Code.
🤖 Generated with Claude Code