Repository navigation
Conversation
setenv/unsetenv do not exist on Windows, which breaks the Windows jobs of CI (vulkan) on master since 27c308e. Map them to _putenv_s, where an empty value removes the variable. Assisted-by: Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Closing for now per maintainer: the Windows test-qsa-fast build failure (setenv/unsetenv) is known and pre-existing on master. The fix in this branch (map to _putenv_s) can be reopened when needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
tests/test-qsa-fast.cpp(from 27c308e) calls POSIXsetenv/unsetenv, so every Windows build with tests fails. CI (vulkan) / windows has failed on master since it landed, and #111 inherits the failure. This maps both to_putenv_s, where an empty value removes the variable, so the test still runs on Windows. It does not skip the test liketest-arg-parserdoes.Measurements
Not applicable: test-only build fix, no runtime code touched.
Correctness:
test-qsa-fastpasses on Linux (gfx1151 box, unchanged code path). The Windows path is verified by this PR's CI.Requirements