Skip to content

Update for fluentd >= 0.14#6

Open
dblN wants to merge 2 commits into
hakobera:masterfrom
dblN:v0.14
Open

Update for fluentd >= 0.14#6
dblN wants to merge 2 commits into
hakobera:masterfrom
dblN:v0.14

Conversation

@dblN

@dblN dblN commented Jan 30, 2018

Copy link
Copy Markdown

Fluentd (>= 0.14) has incompatible API with <= 0.12.
This PR modifies code for Fluentd (>= 0.14).


def create_driver(conf=CONFIG)
Fluent::Test::InputTestDriver.new(Fluent::HerokuSyslogInput).configure(conf)
Fluent::Test::InputTestDriver.new(Fluent::Plugin::HerokuSyslogInput).configure(conf)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use new Fluent::Test::Driver::Input class?


def create_driver(conf=CONFIG)
Fluent::Test::InputTestDriver.new(Fluent::HerokuSyslogHttpInput).configure(conf)
Fluent::Test::InputTestDriver.new(Fluent::Plugin::HerokuSyslogHttpInput).configure(conf)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

Comment thread test/helper.rb
@@ -16,8 +16,6 @@
require 'fluent/log'
require 'fluent/test'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requiring 'fluent/test/driver/input' for Fluentd v0.14 testing is needded.

Comment thread test/helper.rb
require 'fluent/log'
require 'fluent/test'

$log = Fluent::Log.new(STDOUT, Fluent::Log::LEVEL_DEBUG)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants