Resolve memory leaks and a build error#1
Open
mlq wants to merge 2 commits into
Open
Conversation
This patch resolves memory leaks of the variable key_s in _evhtp_request_parser_header_key by adding proper calls to free the previously allocated memory upon failure and return. In addition it checks if the initial allocation of the memory succeeded and acts accordingly.
|
The first patch (Include signal.h for SIGTERM declaration) works and it’s necessary; compilation fails on ‘SIGTERM’ undeclared without it. The second patch (Resolve memory leaks in evhtp.c) causes error in seaf-server: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patches resolves two memory leaks that occur when a call in _evhtp_request_parser_header_key fails as well as when the function returns. The second patch resolves a build error caused by the missing declaration of SIGTERM. For a more detailed description please refer to the single commit messages.