Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/auth_principal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ func TestCORSAllowsBrowserSpaceCredentialExchange(t *testing.T) {
req := httptest.NewRequest(http.MethodOptions, "/xrpc/com.atproto.space.getSpaceCredential", nil)
req.Header.Set(echo.HeaderOrigin, "https://pdsls.dev")
req.Header.Set(echo.HeaderAccessControlRequestMethod, http.MethodPost)
req.Header.Set(echo.HeaderAccessControlRequestHeaders, "atproto-accept-labelers,authorization,content-type,dpop,x-bsky-topics")
req.Header.Set(echo.HeaderAccessControlRequestHeaders, "atproto-accept-labelers,authorization,content-type,dpop,x-bsky-topics,x-future-client-header")
rec := httptest.NewRecorder()
e.ServeHTTP(rec, req)

Expand All @@ -670,7 +670,7 @@ func TestCORSAllowsBrowserSpaceCredentialExchange(t *testing.T) {
t.Fatalf("allow-credentials = %q, want true", got)
}
allowHeaders := strings.ToLower(rec.Header().Get(echo.HeaderAccessControlAllowHeaders))
for _, want := range []string{"authorization", "content-type", "dpop", "atproto-accept-labelers", "x-bsky-topics"} {
for _, want := range []string{"authorization", "content-type", "dpop", "atproto-accept-labelers", "x-bsky-topics", "x-future-client-header"} {
if !strings.Contains(allowHeaders, want) {
t.Fatalf("allow-headers = %q, missing %q", allowHeaders, want)
}
Expand Down
12 changes: 2 additions & 10 deletions server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -260,16 +260,8 @@ func cocoonCORSConfig() middleware.CORSConfig {
AllowOriginFunc: func(origin string) (bool, error) {
return origin != "", nil
},
AllowHeaders: []string{
echo.HeaderOrigin,
echo.HeaderAccept,
echo.HeaderContentType,
echo.HeaderAuthorization,
"DPoP",
"atproto-proxy",
"atproto-accept-labelers",
"x-bsky-topics",
},
// Leave AllowHeaders empty so Echo reflects the browser's requested
// headers instead of requiring every client-specific header here.
AllowMethods: []string{
http.MethodGet,
http.MethodHead,
Expand Down
Loading