Skip to content

Allow Bluesky labeler CORS requests - #132

Merged
haileyok merged 5 commits into
mainfrom
hailey/spaces-dpop-nonce
Aug 25, 2026
Merged

Allow Bluesky labeler CORS requests#132
haileyok merged 5 commits into
mainfrom
hailey/spaces-dpop-nonce

Conversation

@haileyok

Copy link
Copy Markdown
Owner

Summary

  • Allow the atproto-accept-labelers request header used by the Bluesky web client.
  • Fix the notification-list preflight that currently returns 204 but omits a requested header, causing Chrome to block the actual request as CORS.

Changes

  • Add atproto-accept-labelers to Cocoon’s explicit CORS allow-header list.
  • Extend the browser CORS regression test to cover the labeler header.

Validation

  • go test ./server -run "TestCORSAllowsBrowserSpaceCredentialExchange|TestProxyResponseHeadersPreserveCocoonCORS" -count=1
  • go test ./... -count=1
  • go vet ./...
  • go test -race ./server -run "TestCORSAllowsBrowserSpaceCredentialExchange|TestProxyResponseHeadersPreserveCocoonCORS" -count=1
  • git diff --check

Review notes

@haileyok
haileyok marked this pull request as ready for review August 25, 2026 01:03
@haileyok
haileyok merged commit 7edd9a6 into main Aug 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant