Skip to content

Accept nonce-bearing Space DPoP proofs - #129

Merged
haileyok merged 1 commit into
mainfrom
hailey/spaces-dpop-nonce
Aug 24, 2026
Merged

Accept nonce-bearing Space DPoP proofs#129
haileyok merged 1 commit into
mainfrom
hailey/spaces-dpop-nonce

Conversation

@haileyok

Copy link
Copy Markdown
Owner

Summary

  • Fix PDSLS credential-exchange failures caused by nonce-bearing DPoP proofs.
  • Accept the optional nonce claim used by @atcute/oauth-crypto while preserving Space DPoP validation.

Changes

  • Allow an optional nonce claim in Space DPoP proofs and validate that it is a non-empty string.
  • Add nonce support to Cocoon’s proof helper for complete protocol/test coverage.
  • Keep issuance proofs unbound to ath; Space credential issuance still rejects an ath claim.
  • Add a regression test reproducing a nonce-bearing issuance proof.

Validation

  • go test ./space -run TestDPoPProofAcceptsOptionalNonce -count=1
  • go test ./... -count=1
  • go test -race ./... -count=1
  • go vet ./...
  • git diff --check

Review notes

@haileyok
haileyok marked this pull request as ready for review August 24, 2026 23:48
@haileyok
haileyok merged commit c120da1 into main Aug 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant