wait for database user to be created before starting omero-web#6
Open
thushw wants to merge 2 commits intohadim:masterfrom
Open
wait for database user to be created before starting omero-web#6thushw wants to merge 2 commits intohadim:masterfrom
thushw wants to merge 2 commits intohadim:masterfrom
Conversation
Owner
|
The issue with this solution is that root user with this password will not always exist. What does happen if the container is started over a previously created OMERO instance that does not have such a user/password ? Maybe we should start using the new HEALTHCHECK feature of Docker : https://docs.docker.com/engine/reference/builder/#/healthcheck |
Author
|
I think that's a good idea. But I'm not sure what the health check should be looking for. If the health check command tries to login to the server, we must be prepared for the user changing the omero config, so that might not work. Similarly we can't rely on even the credentials of the postgres user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.