Replace deprecated Codecov bash uploader with pinned codecov-action#5384
Open
frenck wants to merge 2 commits into
Open
Replace deprecated Codecov bash uploader with pinned codecov-action#5384frenck wants to merge 2 commits into
frenck wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens the CI coverage upload in the pytest workflow by removing the deprecated, unpinned Codecov bash uploader (curl ... | bash) and replacing it with a commit-SHA-pinned codecov/codecov-action.
Changes:
- Adds a dedicated step to print the human-readable coverage report in CI logs (only on the Python 3.14 matrix leg).
- Replaces the deprecated Codecov bash uploader with
codecov/codecov-actionpinned to a specific commit SHA. - Configures the action to upload
coverage.xml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+101
to
+103
| uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0 | ||
| with: | ||
| files: coverage.xml |
Member
Author
There was a problem hiding this comment.
This isn't needed, as tokenless upload has been enabled.
ludeeus
reviewed
Jul 19, 2026
| scripts/coverage | ||
| curl -sfSL https://codecov.io/bash | bash - No newline at end of file | ||
| uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0 | ||
| with: |
Member
There was a problem hiding this comment.
Should this set fail_ci_if_error: true?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The pytest workflow uploaded coverage with the deprecated Codecov bash uploader, piped straight into a shell without pinning (
curl -sfSL https://codecov.io/bash | bash -). That was the exact vector of the 2021 Codecov supply chain compromise, and it is the only unpinned thing in an otherwise fully SHA-pinned workflow.This replaces it with
codecov/codecov-actionpinned by commit SHA (v7.0.0), consistent with how all other actions in this workflow are pinned. Uploads are tokenless, which is fine for a public repository. The human readable coverage report (scripts/coverage) moved to its own step so it stays visible in the CI logs. Also adds the missing trailing newline to the file.Note: the upload step only runs on the Python 3.14 leg, unchanged from before.
Type of change
Checklist