Return repository_not_found for unknown ids in all websocket commands

[frenck]

Proposed change

Ten websocket handlers dereferenced repositories.get_by_id() without a None check (state, version, beta, download, remove, refresh, release_notes, releases, repositories/clear_new, and repositories/remove). A stale frontend referencing a repository that no longer exists (removed, or renamed) got an AttributeError surfaced as "Unknown error", with a traceback in the Home Assistant log.

This adds a shared resolve_repository() helper that sends a proper repository_not_found error and makes all repository commands use it, including info and ignore which each had their own copy of the guard. Error behavior is now identical across all commands.

Added a parametrized test that sends all 12 commands with an unknown repository id and asserts the structured error response. 10 of the 12 fail on the previous code.

Type of change

• Bugfix (non-breaking change which fixes an issue)

Checklist

• The code change is tested and works locally.
• Local tests pass.
• There is no commented out code in this PR.

[Copilot]

Pull request overview

Standardizes websocket error handling when a client references a repository ID that no longer exists, preventing AttributeError tracebacks from surfacing as generic “Unknown error” responses and avoiding noisy Home Assistant logs.

Changes:

• Introduces a shared resolve_repository() helper that returns a consistent repository_not_found websocket error for unknown repository IDs.
• Refactors all repository-related websocket commands to use the shared resolver (including info and ignore which previously had bespoke guards).
• Adds a parametrized websocket test covering all 12 relevant commands and records API-usage snapshots for each parameterization.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
custom_components/hacs/websocket/helpers.py	Adds resolve_repository() to centralize repository lookup and structured not-found error sending.
custom_components/hacs/websocket/repository.py	Updates all single-repository websocket commands to use resolve_repository() and early-return on unknown IDs.
custom_components/hacs/websocket/repositories.py	Updates multi-repository websocket commands that accept a repository ID to use resolve_repository().
tests/test_websocket.py	Adds a parametrized test asserting consistent repository_not_found responses across all affected websocket commands.
tests/snapshots/api-usage/tests/test_websockettest-unknown-repository-returns-not-found-repository-info.json	Records API-usage snapshot for the repository/info unknown-ID case.
tests/snapshots/api-usage/tests/test_websockettest-unknown-repository-returns-not-found-repository-ignore.json	Records API-usage snapshot for the repository/ignore unknown-ID case.
tests/snapshots/api-usage/tests/test_websockettest-unknown-repository-returns-not-found-repository-state.json	Records API-usage snapshot for the repository/state unknown-ID case.
tests/snapshots/api-usage/tests/test_websockettest-unknown-repository-returns-not-found-repository-version.json	Records API-usage snapshot for the repository/version unknown-ID case.
tests/snapshots/api-usage/tests/test_websockettest-unknown-repository-returns-not-found-repository-beta.json	Records API-usage snapshot for the repository/beta unknown-ID case.
tests/snapshots/api-usage/tests/test_websockettest-unknown-repository-returns-not-found-repository-download.json	Records API-usage snapshot for the repository/download unknown-ID case.
tests/snapshots/api-usage/tests/test_websockettest-unknown-repository-returns-not-found-repository-remove.json	Records API-usage snapshot for the repository/remove unknown-ID case.
tests/snapshots/api-usage/tests/test_websockettest-unknown-repository-returns-not-found-repository-refresh.json	Records API-usage snapshot for the repository/refresh unknown-ID case.
tests/snapshots/api-usage/tests/test_websockettest-unknown-repository-returns-not-found-repository-release-notes.json	Records API-usage snapshot for the repository/release_notes unknown-ID case.
tests/snapshots/api-usage/tests/test_websockettest-unknown-repository-returns-not-found-repository-releases.json	Records API-usage snapshot for the repository/releases unknown-ID case.
tests/snapshots/api-usage/tests/test_websockettest-unknown-repository-returns-not-found-repositories-clear-new.json	Records API-usage snapshot for the repositories/clear_new unknown-ID case.
tests/snapshots/api-usage/tests/test_websockettest-unknown-repository-returns-not-found-repositories-remove.json	Records API-usage snapshot for the repositories/remove unknown-ID case.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.