Restore persistent directory when a download fails

[frenck]

Proposed change

When downloading an update for an installed repository, the persistent directory (persistent_directory in hacs.json) is moved out of the install directory into /tmp before the backup of the old install is created. That backup therefore never contains the persistent directory.

The restore of the persistent directory only happened on the success path. On a failed download, the error path raised before reaching it: the backup restore brought back the old install without the persistent data, which stayed stranded in /tmp and was gone after a reboot.

This change wraps the download steps in try/finally and moves the persistent directory restore into the finally block, so it is always moved back in place. This also covers download paths that raise directly (like "No content to download") instead of going through the validation error branch.

Added a test that upgrades an installed integration with a persistent directory present, injects a download failure, and asserts the user data is still there afterwards. The test fails on the previous code.

Type of change

• Bugfix (non-breaking change which fixes an issue)

Checklist

• The code change is tested and works locally.
• Local tests pass.
• There is no commented out code in this PR.

[Copilot]

Pull request overview

Fixes update/install rollback behavior so a repository’s persistent_directory is always moved back into place, even when the download step fails, preventing user data from being stranded in /tmp and lost on reboot.

Changes:

• Wraps repository download steps in try/finally and restores the persistent directory in finally.
• Adds a regression test covering a failed update download with an existing persistent directory.
• Adds an API-usage snapshot for the new test.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
custom_components/hacs/repositories/base.py	Ensures persistent directory restoration runs on both success and failure paths during install/update.
tests/repositories/test_update_repository.py	Adds regression test verifying persistent user data survives a failed download.
tests/snapshots/api-usage/tests/repositories/test_update_repositorytest-update-repository-entity-download-failure-keeps-persistent-directory.json	Records expected API usage for the new regression test.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.