Skip to content

Refactor handling in HacsRepository to use the new API client #4902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ludeeus wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −5
Open

Refactor handling in HacsRepository to use the new API client #4902

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91bf63b
Refactor exception handling in HacsRepository to use the new API client
ludeeus Nov 2, 2025
b2548cf
Merge main into use-new, resolving import conflict in base.py
Copilot Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions custom_components/hacs/repositories/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@

from aiogithubapi import (
AIOGitHubAPIException,
AIOGitHubAPINotModifiedException,
GitHubException,
GitHubNotModifiedException,
)
import attr
from homeassistant.helpers import device_registry as dr, issue_registry as ir
Expand Down Expand Up @@ -1012,11 +1012,17 @@ async def async_get_legacy_repository_object(
) -> tuple[AIOGitHubAPIRepository, Any | None]:
"""Return a repository object."""
try:
repository = await self.hacs.github.get_repo(self.data.full_name, etag)
return repository, self.hacs.github.client.last_response.etag
except AIOGitHubAPINotModifiedException as exception:
response = await self.hacs.githubapi.repos.get(
repository=self.data.full_name,
etag=etag,
)
return AIOGitHubAPIRepository(
client=self.hacs.github.client,
attributes=response.data._raw_data,
Comment thread
ludeeus marked this conversation as resolved.
), response.etag
except GitHubNotModifiedException as exception:
raise HacsNotModifiedException(exception) from exception
except (ValueError, AIOGitHubAPIException, Exception) as exception:
except Exception as exception:
Comment thread
ludeeus marked this conversation as resolved.
raise HacsException(exception) from exception

def update_filenames(self) -> None:
Expand Down