Skip to content

[HCK-12933] Fix connection with Entra ID bug#120

Merged
chulanovskyi-bs merged 8 commits intodevelopfrom
fix-bug
Oct 3, 2025
Merged

[HCK-12933] Fix connection with Entra ID bug#120
chulanovskyi-bs merged 8 commits intodevelopfrom
fix-bug

Conversation

@bigorn0
Copy link
Contributor

@bigorn0 bigorn0 commented Oct 2, 2025

Content

Connecting to our Azure Synapse wasn't working

  • Initially because an issue in the error callback with the logger not being defined
  • Once this was overcome, the root of the issue appeared: Oauth flow wasn't working.
  • Then i aligned the implementation with the one we have for Azure Devops which is working fine.

Reference:
https://app.gitbook.com/o/HBtg1gLTy0nw4NaX0MaV/s/k3cNzEeXGnIxGNnOQdDa/studio-core/workgroup-edition/integrating-with-providers/azure-devops/entra-id-multitenant-apps-for-oauth
https://app.gitbook.com/o/HBtg1gLTy0nw4NaX0MaV/s/k3cNzEeXGnIxGNnOQdDa/studio-core/workgroup-edition/integrating-with-providers/azure-devops/oauth

https://github.com/hackolade/studio/blob/032e3a78fc4080a659bb8e6a6edfd6acff6e2dfd/services/gitService/gitProviders/providers/azureDevops/azureDevopsProvider.js#L1415

Technical details

  • some deps updates
  • logger callback this issue
  • Align OAuth logic with the one used in studio for connecting to azure devops using Oauth / Entra ID

@bigorn0 bigorn0 changed the title Fix connection with Entra ID bug [HCK-12933] Fix connection with Entra ID bug Oct 2, 2025
@bigorn0 bigorn0 marked this pull request as ready for review October 2, 2025 08:35
@serhii-filonenko serhii-filonenko enabled auto-merge (squash) October 2, 2025 08:59
* HCK-12948: install hck-fetch

* HCK-12948: replace axios by hck-fetch

* HCK-12948: remove unused packages
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2025

@chulanovskyi-bs chulanovskyi-bs merged commit b2678a6 into develop Oct 3, 2025
1 check passed
@chulanovskyi-bs chulanovskyi-bs deleted the fix-bug branch October 3, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants