Skip to content

Fix unit tests and parameterize dataset year#2075

Merged
ryanfchase merged 7 commits intomainfrom
ssiegal.fallback-to-prior-year
Feb 6, 2026
Merged

Fix unit tests and parameterize dataset year#2075
ryanfchase merged 7 commits intomainfrom
ssiegal.fallback-to-prior-year

Conversation

@ssiegal1
Copy link
Contributor

@ssiegal1 ssiegal1 commented Feb 3, 2026

If current year's data is not available, fall back to prior year and adjust Date Range UI to reflect this

@ryanfchase
Copy link
Member

@ssiegal1 so sorry, there's an issue with this PR. We have a new set of designs that we need to implement, which nullifies the need to "fall back to previous year's dataset". My fault, this is what happens when I'm behind on dev tickets. In short, check out the user flow here: https://www.figma.com/design/eF63O8yIGz2soQ4JJFfyoK/311_Data_UXUI?node-id=21161-12165&t=QDEfQjpBEEpu9TuZ-4

@ssiegal1 ssiegal1 changed the title Fall back to prior year's data if current year dataset doesn't exist yet. Fix unit tests and parameterize dataset year Feb 6, 2026
Copy link
Member

@ryanfchase ryanfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanfchase ryanfchase merged commit 9b57cb7 into main Feb 6, 2026
@ryanfchase ryanfchase deleted the ssiegal.fallback-to-prior-year branch February 6, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants