Skip to content

A few minor fixes to get tests running, and parameterize the year when downloading Huggingface dataset#2074

Merged
ryanfchase merged 3 commits intomainfrom
ssiegal.fix-year
Feb 6, 2026
Merged

A few minor fixes to get tests running, and parameterize the year when downloading Huggingface dataset#2074
ryanfchase merged 3 commits intomainfrom
ssiegal.fix-year

Conversation

@ssiegal1
Copy link
Contributor

@ssiegal1 ssiegal1 commented Feb 3, 2026

Fixes #{issue number here}

  • Up to date with main branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

Copy link
Member

@ryanfchase ryanfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup on logic to remove hardcoded years, but it's missing a mechanic to choose the corresponding dataset for that year. "https://data.lacity.org/api/views/h73f-gn57/rows.csv" will always correspond to 2025. We need to have a lookup table to map the year to the corresponding dataset URL.

See this example of what I mean in DbProvider.jsx...

So you'll want to make sure you are additionally providing the 2026 link...

Click to see screenshot of how to obtain link to 2026 dataset Image

@ryanfchase ryanfchase merged commit bb64c3c into main Feb 6, 2026
@ryanfchase ryanfchase deleted the ssiegal.fix-year branch February 6, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants