A few minor fixes to get tests running, and parameterize the year when downloading Huggingface dataset#2074
Merged
ryanfchase merged 3 commits intomainfrom Feb 6, 2026
Merged
Conversation
2b1f19f to
bb64c3c
Compare
ryanfchase
requested changes
Feb 3, 2026
Member
ryanfchase
left a comment
There was a problem hiding this comment.
Good cleanup on logic to remove hardcoded years, but it's missing a mechanic to choose the corresponding dataset for that year. "https://data.lacity.org/api/views/h73f-gn57/rows.csv" will always correspond to 2025. We need to have a lookup table to map the year to the corresponding dataset URL.
See this example of what I mean in DbProvider.jsx...
So you'll want to make sure you are additionally providing the 2026 link...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #{issue number here}
mainbranchAny questions? See the getting started guide