Conversation
Implement BottomNavigation (capsule-shaped fixed bar) and BottomNavigationItem (icon + label with active/disabled states) using semantic design tokens. Includes Ladle stories for active state and disabled item variations. Closes #58 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR introduces a new bottom navigation UI component for the frontend, along with Storybook stories to validate active/disabled states and routing behavior.
Changes:
- Added
BottomNavigationandBottomNavigationItemcomponents with fixed bottom positioning and active-state styling. - Implemented a disabled rendering path for navigation items.
- Added Storybook stories using
MemoryRouterto demonstrate route-driven active states.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/frontend/app/components/ui/bottom-navigation.tsx | New bottom navigation + item components built on NavLink, including active/disabled styling and accessibility attributes. |
| packages/frontend/app/components/bottom-navigation.stories.tsx | Storybook stories exercising active route behavior and disabled item rendering via MemoryRouter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
- Remove redundant aria-current on inner span (NavLink handles it) - Remove unused ...props spread (type doesn't extend NavLink props) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
関連 Issue
Closes #58
変更内容
BottomNavigation（カプセル型の固定バー）とBottomNavigationItem（アイコン＋ラベル）を実装NavLinkによる active 状態の自動判定（bg-alpha-black-25で表現）opacity-40+ リンク無効化）pb-[env(safe-area-inset-bottom)]）aria-label,aria-current="page",aria-disabled,focus-visible:ring対応動作確認
設計メモ
rounded-full）の浮遊バーとして実装bg-primary、テキスト・アイコンはtext-primary-foregroundbg-alpha-black-25による色差（Issue の Open Question に対する暫定実装）🤖 Generated with Claude Code