Skip to content

Parse DAILY_SUMMARY as a boolean like a sane person #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MMK21Hub merged 3 commits into from
May 30, 2026
Merged

Parse DAILY_SUMMARY as a boolean like a sane person #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82b0baf
Parse DAILY_SUMMARY as a boolean like a sane person
MMK21Hub May 30, 2026
2c9a5ee
Update docs for DAILY_SUMMARY
MMK21Hub May 30, 2026
cbff4f0
Consistently show default values for the optional env vars
MMK21Hub May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/deployment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ Note: These steps have to be done by a Workspace Admin (otherwise it will be una
OTEL_EXPORTER_OTLP_LOGS_BASIC_AUTH="username:password"
# You can change the OTel service name if you want, but you don't have to
OTEL_SERVICE_NAME="nephthys"
# Setting this to any value disables daily summary messages (yes, this is counter-intuitive and will be changed soon)
DAILY_SUMMARY=""
# Set this to false to disable daily summary messages in the BTS channel
DAILY_SUMMARY=true
# Set the log level (defaults to "WARNING" in production)
LOG_LEVEL="WARNING"
# Override the log level for console output
Expand All @@ -96,12 +96,12 @@ Note: These steps have to be done by a Workspace Admin (otherwise it will be una

# Allow the poster of a question to give feedback after their ticket is resolved
# Feedback is stored in the "Feedback" table. Disabled by default.
ENABLE_FEEDBACK=true
ENABLE_FEEDBACK=false

# Optional: Enable stale ticket auto-close
# Tickets inactive for this many days will be automatically closed
# Leave unset to disable
STALE_TICKET_DAYS="7"
STALE_TICKET_DAYS="" # e.g. 7
```

4. Don't forget to click **Save All Environment Variables**
Expand Down
4 changes: 2 additions & 2 deletions nephthys/utils/env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ def __init__(self):
self.slack_bts_channel = os.environ.get("SLACK_BTS_CHANNEL", "unset")
self.slack_maintainer_id = os.environ.get("SLACK_MAINTAINER_ID", "unset")
self.program = os.environ.get("PROGRAM", "summer_of_making")
self.daily_summary = True if not os.environ.get("DAILY_SUMMARY") else False
self.enable_feedback = get_environ_bool("ENABLE_FEEDBACK", False)
self.daily_summary = get_environ_bool("DAILY_SUMMARY", default=True)
self.enable_feedback = get_environ_bool("ENABLE_FEEDBACK", default=False)
self.app_title = os.environ.get("APP_TITLE", "helper heidi")

self.port = int(os.environ.get("PORT", 3000))
Expand Down
Loading