Open
Conversation
AdamEXu
approved these changes
Aug 13, 2024
matytyma
approved these changes
Aug 13, 2024
Member
|
hey, I can't approve & merge this without thorough testing. |
rutmanz
reviewed
Aug 14, 2024
AdamEXu
approved these changes
Aug 14, 2024
AdamEXu
left a comment
There was a problem hiding this comment.
i already said i approved, why did you request a review?
matytyma
approved these changes
Aug 14, 2024
rutmanz
approved these changes
Aug 16, 2024
lbirkert
commented
Aug 16, 2024
Author
|
(had to undo the change, as it would be a bug not to, and pixel already said this would be attacked in a future PR) |
Member
|
Tested and the code lgtm. Will merge when I get home. (Merging will require bot downtime) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #151
This has several benefits: