Skip to content

Fix: Add missing resetHubOrganizationData interface method#212

Open
arzola wants to merge 1 commit intoh5p:masterfrom
arzola:master
Open

Fix: Add missing resetHubOrganizationData interface method#212
arzola wants to merge 1 commit intoh5p:masterfrom
arzola:master

Conversation

@arzola
Copy link
Contributor

@arzola arzola commented Mar 10, 2026

This method is part of the interface and it's conflicting with the new 1.28.0 core

PHP Fatal error: Class H5PWordPress contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (H5PFrameworkInterface::resetHubOrganizationData)

This method is part of the interface and it's creating conflicts with the new 1.28.0 core
@arzola
Copy link
Contributor Author

arzola commented Mar 10, 2026

cc @otacke

@arzola arzola changed the title Add resetHubOrganizationData method required method Fix: Add resetHubOrganizationData method required method Mar 10, 2026
@arzola arzola changed the title Fix: Add resetHubOrganizationData method required method Fix: Add missing resetHubOrganizationData interface method Mar 10, 2026
@otacke
Copy link
Contributor

otacke commented Mar 10, 2026

@arzola I am not a maintainer here.

@arzola
Copy link
Contributor Author

arzola commented Mar 10, 2026

@otacke I'm sorry :) my bad by any chance do you know who can I ping for this? the latest update broke our integrations

@otacke
Copy link
Contributor

otacke commented Mar 10, 2026

@arzola The latest update broke a couple of things. This is a new one - but your setup must be special. This very problem has not faced up so far. H5P Group is sorting things out and are supposed to release a fix shortly. I think @icc is working on it.

@icc
Copy link
Member

icc commented Mar 11, 2026

I am not seeing this when downloading 1.17.2 on a fresh install. Are you sure you are downloading the correct zip file from wordpress.org?

@arzola
Copy link
Contributor Author

arzola commented Mar 11, 2026

@icc Yes, I know it's a tricky one in some of our environments works because (they have an older version of the h5p core library [1.27]) but as soon we update the h5p core to 1.28 it will fail because the H5PFrameworkInterface contains a resetHubOrganizationData method to be "implemented" and in this plugin we are implementing H5PFrameworkInterface so this method should be included without body if it's just adhering to the interface to avoid Fatal errors.

See: https://github.com/h5p/h5p-php-library/blob/master/h5p.classes.php#L675

Some our our installations download the hew h5p core and others don't (not entirely sure how the core is getting downloaded on standalone installations but we are using composer and packagist)

I also downloaded the 1.28 tagged version of the core and it does contains the method in the interface.

So I think in order to make this plugin more reliable we need to do this because this implementer is not adhering to the Interface protocol.

@icc
Copy link
Member

icc commented Mar 12, 2026

WordPress has it's own branch/version of Core. You need to use the commit for the submodules that is part of the official plugin release, anything else is unsupported. E.g. if you go to https://github.com/h5p/h5p-wordpress-plugin/tree/1.17.2 you should see the relevant version in use by the submodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants