Fix: Add missing resetHubOrganizationData interface method#212
Fix: Add missing resetHubOrganizationData interface method#212arzola wants to merge 1 commit intoh5p:masterfrom
Conversation
This method is part of the interface and it's creating conflicts with the new 1.28.0 core
|
cc @otacke |
|
@arzola I am not a maintainer here. |
|
@otacke I'm sorry :) my bad by any chance do you know who can I ping for this? the latest update broke our integrations |
|
I am not seeing this when downloading 1.17.2 on a fresh install. Are you sure you are downloading the correct zip file from wordpress.org? |
|
@icc Yes, I know it's a tricky one in some of our environments works because (they have an older version of the h5p core library [1.27]) but as soon we update the h5p core to 1.28 it will fail because the See: https://github.com/h5p/h5p-php-library/blob/master/h5p.classes.php#L675 Some our our installations download the hew h5p core and others don't (not entirely sure how the core is getting downloaded on standalone installations but we are using composer and packagist) I also downloaded the 1.28 tagged version of the core and it does contains the method in the interface. So I think in order to make this plugin more reliable we need to do this because this implementer is not adhering to the Interface protocol. |
|
WordPress has it's own branch/version of Core. You need to use the commit for the submodules that is part of the official plugin release, anything else is unsupported. E.g. if you go to https://github.com/h5p/h5p-wordpress-plugin/tree/1.17.2 you should see the relevant version in use by the submodules. |
This method is part of the interface and it's conflicting with the new 1.28.0 core