When filling user names, be sure to pull from entire network#194
Open
boonebgorges wants to merge 1 commit intoh5p:masterfrom
Open
When filling user names, be sure to pull from entire network#194boonebgorges wants to merge 1 commit intoh5p:masterfrom
boonebgorges wants to merge 1 commit intoh5p:masterfrom
Conversation
On Multisite installations, the user_ids in H5P results may correspond to network users who are not members of the current site. The proposed change tells WP to pull data corresponding to these user_ids, regardless of whether they have a role on the current site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When filling user names using
get_users(), the default WP behavior is to pull users who have a role on the current site. If H5P is running on a specific site in a Multisite network, and if a logged-in user interacts with a piece of H5P content but that user does not have a role on the specific site where H5P is active, then the user's name will be left blank in the Dashboard 'Results' views. The proposed change tells WP to pull up the user corresponding to the provideduser_id, regardless of whether that user has a role on the current site.