Support tuple structs in wrap_impl!#867
Open
HarrisonMc555 wants to merge 2 commits intogyscos:mainfrom
Open
Conversation
Change the fragment specifier used in `wrap_impl!` from `ident` to `tt`. Using `ident` was sufficient for "standard" structs with named fields. However, tuple structs are accessed via index numbers, which are not matched by `ident`. Although using `literal` for tuple indices seems like it should work, it does not. Sidestep this issue by matching an `tt`, i.e. any valid token tree.
Owner
|
Thanks for the PR! Would you mind adding a unit test that makes sure this macro works with both a named struct and a tuple struct? |
Author
|
Sure thing! There was already a doc test, but I added a unit test. Right now it's mostly just exercising that you can invoke the macro without causing compiler errors. Let me know if there's anything else you'd like to see tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the fragment specifier used in
wrap_impl!fromidenttott. Usingidentwas sufficient for "standard" structs with named fields. However, tuple structs are accessed via index numbers, which are not matched byident. Although usingliteralfor tuple indices seems like it should work, it does not.Sidestep this issue by matching an
tt, i.e. any valid token tree.Fixes #866