[Windows] smv error messages get truncated if they contain a Unicode character

[przemo20]

Example steps to reproduce

1. Download the zipped version of SmartVersion https://www.smartversion.com/smartvs400_x64.zip and extract it somewhere
2. Download the pl-pl_windows_10_consumer_editions_version_22h2_updated_dec_2024_x64_dvd_52d3c74b.svf file from here (https://cloud.mail.ru/public/RZwn/9njDGfuYi/22H2_19045/5247_dec_2024/%24Consumer/pl-pl_windows_10_consumer_editions_version_22h2_updated_dec_2024_x64_dvd_52d3c74b.svf) and move it to the folder you extracted SmartVersion to
3. Install a Polish language pack for Windows, change the Windows language to Polish then relogin to your Windows account for the changes to take effect
4. Open Windows command prompt by either going to the folder with extracted files, clicking on the address bar, entering cmd and pressing Enter, or by just opening cmd and then cd to that folder (from step 1 and 2)
5. Enter the following command in the command prompt window and run it:
   smv x pl-pl_windows_10_consumer_editions_version_22h2_updated_dec_2024_x64_dvd_52d3c74b.svf -br .
   (prerequisite: make sure there's no en-us_windows_10_consumer_editions_version_22h2_updated_dec_2024_x64_dvd_52d3c74b.iso file in this folder, since we want to see an error that this file is missing)

Actual behavior

Only the first two letters from the error message will be printed after message :. The program fails to print the letter ż (and the rest of the text after that).

If I run then e.g. the ren jfasjjkdsajrw.a hdsajkhdjksanwr.b command (the jfasjjkdsajrw.a file doesn't exist), I see get the same error message, but it is printed correctly:

And here's how this looks when I run the command on English Windows:

If I run the same command, but on Windows with the system language set to Russian, nothing gets printed after the message : text.

Expected behavior

The error messages should be displayed in full.

Troubleshooting information

OS: Windows 11 Pro 23H2 build 22631.4602 (64-bit)
OS language: Polish
SmartVersion version: 4.0

[gvollant]

can you try branch feature/fix_alloc_unicode @przemo20

[przemo20]

Yep, that branch seems to fix this*.

*Although I was having some issues compiling the code on Windows, since when building it in Visual Studio it couldn't find the following two files:

..\smartversion\external\xz\src\liblzma\check\crc32_table.c
..\smartversion\external\xz\src\liblzma\check\crc64_table.c

The xz version downloaded by the external_rebuild.sh script doesn't seem to include them. There are these files though:

xz-5.8.1\src\liblzma\check\crc32_table_be.h
xz-5.8.1\src\liblzma\check\crc32_table_le.h
xz-5.8.1\src\liblzma\check\crc64_table_be.h
xz-5.8.1\src\liblzma\check\crc64_table_le.h

Not sure what's with that and whether I did something wrong.