v0.11.1: bump Dockerfile Rust toolchain to 1.85 - #48
Merged
Conversation
The Docker job in v0.11.0's release workflow still failed:
error: failed to parse manifest at .../clap_lex-1.1.0/Cargo.toml
Caused by: feature `edition2024` is required
The package requires the Cargo feature called `edition2024`, but
that feature is not stabilized in this version of Cargo (1.83.0).
`clap_lex 1.1.0` (and several other transitive deps including
`cpufeatures 0.3.0`) need Rust/Cargo 1.85+ — they declare
`edition = "2024"`. The Dockerfile was still pinned to
`rust:1.83-bookworm`, so cargo couldn't even parse the manifest;
the actual symptom that surfaced was a confusing
`/usr/local/bin/rusnel: not found` during the multi-stage
`COPY --from=builder`.
Bump the Dockerfile pin to `rust:1.85-bookworm`. v0.10.0, v0.10.1,
and v0.11.0 GHCR images don't exist for this reason; v0.11.1 will.
(This is a re-roll of the closed PR #46, which had the same
one-line fix but was based on a now-stale 0.10.2 version.)
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Docker job in v0.11.0's release workflow still failed with the same misleading "binary not found" error. The real cause is buried higher in the build log:
```
error: failed to parse manifest at .../clap_lex-1.1.0/Cargo.toml
Caused by: feature `edition2024` is required
The package requires the Cargo feature called `edition2024`, but
that feature is not stabilized in this version of Cargo (1.83.0).
```
`clap_lex 1.1.0` (and `cpufeatures 0.3.0` and a few others in the dep tree) declare `edition = "2024"` and need Cargo 1.85+. The Dockerfile was still pinned to `rust:1.83-bookworm`, so cargo couldn't even parse the manifest — the cargo build failed silently inside the BuildKit stage, surfacing only as a downstream `/usr/local/bin/rusnel: not found` during the multi-stage `COPY --from=builder`.
Bump the pin to `rust:1.85-bookworm`. One-line fix.
This is a re-roll of #46, which had the same one-line fix but was based on a now-stale 0.10.2 version (master is past v0.11.0). #46 has been closed in favour of this PR.
Versioned 0.11.0 → 0.11.1 (patch — release-infra fix only).
Made with Cursor