Add DisableAutoDispose() to opt out of automatic IDisposable handling#146
Open
svermeulen wants to merge 1 commit into
Open
Add DisableAutoDispose() to opt out of automatic IDisposable handling#146svermeulen wants to merge 1 commit into
svermeulen wants to merge 1 commit into
Conversation
…sposable handling
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an opt-in
ContainerBuilder.DisableAutoDispose()builder method. When set, the resulting container will not register resolved instances or registered values for automatic disposal.Reflex's automatic
IDisposablehandling uses a fixed reverse-construction order (LIFO over a single stack). For projects that want to drive their own ordered shutdown sequence based on other criteria (eg. dependency-aware ordering, explicit attributes, etc.) the auto-dispose pass becomes a problem. Also, some projects need Dispose to happen earlier than it does for Container (eg. before scene unloads, since some dispose logic needs valid access to objects in unity scene.)For these reasons this setting is extremely useful
Type of change
How Has This Been Tested?
Ran via Unity Test Runner. All tests passed (though GarbageCollectionTests were skipped since it was run in debug)
Checklist: