Open
Conversation
instead of a string
de65083 to
6655f74
Compare
d13beed to
fbb804a
Compare
codeview annotation intrinsiccodeview_annotation intrinsic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new intrinsic called
codeview_annotationwhich lowers tollvm.codeview.annotationand allows users to emit arbitraryS_ANNOTATIONrecords into PDB files.Motivation
In Microsoft we are working on supporting Windows driver development in Rust.
codeview_annotationis needed to implement a feature called WPP tracing which requires strings from trace statements to be written to the PDB at compile time.Basically the user writes a trace statement like this in the driver:
which expands to a call to
codeview_annotation:and the string arguments get written to the PDB.
Later at runtime trace viewing tools extract those strings from the PDB, combine them with the stream of variables (e.g.
byte_countandelapsed_ms) coming out of the driver and produce a human readable log.This keeps tracing efficient by avoiding costly I/O of strings at runtime and also helps with not leaking implementation details of drivers.
The intrinsic could also be useful in general for other use cases where you need to embed some user-specific information in the PDB.
API
The intrinsic is declared as:
and is publicly exposed through a macro with the same name.
The
&[&str]parameter is required to be aconstas it must be available at compile time in order to be lowered tollvm.codeview.annotation. Non-constarguments are rejected with a compiler error.Supported Platforms
Only LLVM on msvc is supported. It is a no-op on other platforms.
Implementation
Calls to
codeview_annotationare lowered toStatementKind::Intrinsicat MIR building time. The string arguments are extracted from THIR and stored in the newly introduced variantNonDivergingIntrinsic::CodeviewAnnotation(Box<[Symbol]>)which is ultimately lowered tollvm.codeview.annotationin the backend.We have chosen to collect the string arguments at the time of THIR->MIR translation because it is easier to do so. The other option was to do it during codegen but that would have required walking chains of MIR locals backwards which was more complicated.
Future Work
Ideally we should have implemented this feature using const generics e.g.:
as that guarantees the compile time availability of the inputs. However, we are blocked on
adt_const_paramsand especiallyunsized_const_params. Whenever these features get stabilized we can update the implementation to make use of them.