fix: Windows CI test failure and compilation warnings#41
Merged
Conversation
- Windows CI: use --no-run (compile-only) since portable-pty/Tauri native deps lack ConPTY DLLs on GitHub Actions runners (STATUS_ENTRYPOINT_NOT_FOUND). macOS keeps full test execution. - pty.rs: gate Duration/Instant imports with cfg(not(windows)) - worktree.rs: replace match-on-constants with if-chain for RestartManager app type (windows_sys constants aren't pattern-safe) - system.rs: suppress dead_code on test helper `remove()`, gate `shell_quote` with cfg(unix)
… processes u32::MAX (4294967295) overflows to -1 in i32, and `kill -TERM -1` on Linux sends SIGTERM to every process the caller can signal — including the CI runner. Fix: use PID 4000000 (high but valid) in test, and add i32::MAX guard in terminate_process_impl to reject PIDs that would overflow to negative values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-run(compile-only) — portable-pty/Tauri native deps lack ConPTY DLLs on GitHub Actions runners (STATUS_ENTRYPOINT_NOT_FOUND). macOS keeps full test execution.Duration/Instantbehind cfg gate),windows_sysRestartManager constants in match patterns, dead test helper code.Test plan
cargo clippy --lib -- -D warningszero warningscargo test --lib -- --test-threads=1443 passedNote
Previous PR #39 was squash-merged with a stale destructive commit from pre-push hook state corruption — reverted in #40. This PR is a clean replacement.