update version#17
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Gumlet WordPress plugin release metadata to v1.4.1, reflecting updated WordPress/PHP compatibility requirements and aligning documentation with recent runtime fixes and script-loading changes.
Changes:
- Bump plugin version to 1.4.1 and update minimum requirements to WordPress 6.0+ and PHP 7.4+.
- Update frontend script loading to register/enqueue
gumlet.jsin the footer and mark it async viawp_script_add_data. - Document 1.4.1 fixes in both
readme.txtandchangelog.txt(with one duplication issue noted in review comments).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| readme.txt | Updates compatibility headers (WP/PHP/tested) and adds the 1.4.1 changelog entry. |
| includes/class-gumlet.php | Adjusts gumlet.js enqueue behavior; adds path helpers; tightens excluded post-type check; passes $is_s3_host into image rewriting. |
| gumlet.php | Bumps plugin header version and adds WP/PHP requirement headers. |
| changelog.txt | Adds 1.4.1 entry and updates 1.4.0 section (currently contains duplicated bullets vs 1.3.20). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
10
to
19
| = 1.4.0 = | ||
| * Advanced setting: Auto Resize (auto_resize). When disabled, img src is set directly to the Gumlet URL instead of the placeholder pixel (no viewport-based resize via gumlet.js for those tags). | ||
| * Advanced setting: Auto Resize (auto_resize). When disabled, img src is set directly to the Gumlet URL instead of the placeholder pixel. | ||
| * Fix DOM parsing for img/source tags: do not entity-encode the whole tag before loadHTML (was preventing any img from being found). | ||
| * Support SVG URLs in replace_image_url. | ||
| * Normalize JSON-style escapes in fragments (wp_unslash, \/) before parsing. | ||
|
|
||
| = 1.3.20 = | ||
| * Fix DOM parsing for img/source tags: do not entity-encode the whole tag before loadHTML (was preventing any img from being found). | ||
| * Support SVG URLs in replace_image_url. | ||
| * Normalize JSON-style escapes in fragments (wp_unslash, \/) before parsing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.