Conversation
Introduces a Playwright-based performance testing infrastructure using CDP for metrics collection. Four benchmark scenarios (scroll, drag within list, drag between lists with autoscroll, dynamic-height scroll) run with 4x CPU throttling, 5 iterations each, and produce aggregated statistics (mean, median, p95, stddev). Results can be compared against a baseline to detect regressions above a configurable threshold.
Add --output flag to compare.ts so results can be written to a file. The CI workflow now writes to $GITHUB_STEP_SUMMARY, making the comparison table visible directly on the Actions run page.
Add perf:report script that formats raw benchmark metrics as a readable markdown table. The CI workflow now posts results directly to the PR as a comment (updated on re-runs) and writes to the GitHub Job Summary. Removed baseline comparison from CI — the report shows current state.
Performance Benchmark Results
drag-between-lists-autoscroll-1000
drag-within-list-1000
dynamic-height-scroll
scroll-2000-items
Performance Comparison (threshold: 25%)
No significant regressions detected. |
- Use Bessel's correction (n-1) for sample stddev in statistics
- Remove pre-rounding before aggregation in all scenario files
- Fix test name to match actual drag target (item 7, not item 10)
- Extract shared extractScenarios into reusable module
- Add forced GC via CDP before each measurement iteration
- Add droppedFrames (>16.7ms) and p99FrameTime metrics
- Rename report column from p95 to Max (honest with 5 samples)
- Fix misleading warmup wording in report header
- Add waitForLoadState('networkidle') after page navigation
- Add artifact retention-days and TODO for perf:compare in CI
Add baseline comparison step to CI workflow. The PR comment now includes both raw benchmark results and the diff table against the committed baseline. Steps use `if: always()` so the comment posts even when a regression is detected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.