Overall printf rework#33
Merged
Merged
Conversation
…or modern formatting and clarity.
…and raw pointers to simplify ownership and improve performance.
…improved code maintainability.
…debase for cleaner output handling. Also implements #14.
…g with `fmt::format` for better type safety and readability.
gulrak
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the age of the code there was a lot of printf-family formatting going on in Vorlage. Some of it artificially introduced length limits, other places might even be seen as a risk factor. To modernise and mitigate the whole aspect of Vorlage, since its main work is parsing and formatting, I worked my way through all the code to get rid of these and convert them into fmtlib based formatting.