fix: add types:node to tsconfig for TypeScript 6 compatibility#64
Merged
Conversation
TypeScript 6 no longer implicitly includes Node.js globals (process, Buffer, NodeJS namespace, etc.). Explicit `types: ["node"]` is required. Unblocks dependabot PR #60 (typescript 5→6 bump).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"types": ["node"]totsconfig.jsoncompiler optionsContext
TypeScript 6 (coming in dependabot PR #60) no longer implicitly includes Node.js globals. Without this change,
process,Buffer,NodeJS,child_process,fs/promises,path, andosall fail withTS2591. This is a one-liner fix that unblocks that upgrade.Merging this first makes PR #60 mergeable without any additional changes.
Test plan
npm run typecheck— passes clean