Log GetClient errors with proxy identity and connspec#40
Merged
riccardo-perotti merged 3 commits intoApr 17, 2026
Conversation
Errors from GetClient() in the service proxy loop were silently discarded due to := scoping, causing 'not found: %!s(<nil>)' in error messages with no diagnostic information. Now logs each failure with the proxy ident and connspec, and propagates the last error to the outer scope so the 'not found' message includes the actual cause. JiraID: ROP-9188 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The CircleCI config was using Go 1.10.3 and dep (both long deprecated) and the deploy key was no longer valid. Replace with a GitHub Actions workflow using Go 1.26 that runs go build and go vet. Tests are omitted from CI as they require live SCAMP infrastructure (/etc/SCAMP/soa.conf) that is not available in GitHub Actions runners. JiraID: ROP-9188 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jsimmons-flowspace
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetClient()errors inMakeJSONRequest's service proxy loop were silently discarded due to:=scoping, making it impossible to diagnose connection failures from logsError.PrintfGetClienterror to the outererrso the "not found" message includes the actual cause instead of%!s(<nil>)Context
This is a diagnostic change to help root-cause a production incident in intapi-go where all requests returned 401 with
"Request failed: main.User.login not found: %!s(<nil>)". The actualtls.Dialerror was being swallowed.Jira Tickets
https://gudtech.atlassian.net/browse/ROP-9188
🤖 Generated with Claude Code