delete S3 Watcher (since we and others use queue based ingestion now)#4645
Open
twrichards wants to merge 1 commit intomainfrom
Open
delete S3 Watcher (since we and others use queue based ingestion now)#4645twrichards wants to merge 1 commit intomainfrom
twrichards wants to merge 1 commit intomainfrom
Conversation
twrichards
added
the
maintenance
Contributor
Author
|
Hey @AndyKilmory please could I get a review of this given I imagine you're off S3 Watcher now |
Collaborator
|
Hi @twrichards, I think we're happy for you to remove the S3 watcher code - just checking with Richard LE for confirmation and will let you know once he's got back to me. Thanks |
twrichards
force-pushed
the
remove-s3watcher
branch
from
4e72933 to
8170a7a
Compare
Collaborator
|
Have spoken with Ricahrd LE and he is happy for S3 Watcher to be removed given bespoke BBC sync loader doesn't use it and it will be retired in coming weeks |
andrew-nowak
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #4026 and #4201 (plus lots of follow-up PRs) we have been using queue based ingestion for some time, rather than S3 Watcher - now is finally the team to clean-up.