This repository was archived by the owner on Jan 6, 2025. It is now read-only.
feat: Alternative Ophan Implementation - #2379
Open
jimhunty wants to merge 4 commits into
Open
Conversation
jimhunty
force-pushed
the
feat/alternative-ophan-implementation
branch
from
February 21, 2024 09:03
187bc32 to
51696c8
Compare
jimhunty
force-pushed
the
feat/alternative-ophan-implementation
branch
from
March 11, 2024 08:09
6345cec to
cf30bbb
Compare
jimhunty
marked this pull request as ready for review
March 11, 2024 08:14
jimhunty
force-pushed
the
feat/alternative-ophan-implementation
branch
from
March 13, 2024 07:58
2d620f5 to
d422b73
Compare
jimhunty
force-pushed
the
feat/alternative-ophan-implementation
branch
from
March 14, 2024 07:39
c39cac6 to
2ed2119
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you doing this?
Previously we had a native implementation for Ophan. This was built using the native libraries with a Multiplatform Kotlin wrapper. However, this had performance issues and become unmaintained.
We have since attempted to use the Ophan npm library, however, this requires the
documentobject which is not available in React Native as its not a web browser bases solutionAs a result, we have dissected the endpoints used on
theGuardian.comand made an attempt to replicate from inspecting the network console.Changes
viewId