Skip to content

Fix flaky specs on TruffleRuby #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrykonchin wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −4
Open

Fix flaky specs on TruffleRuby #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b75dde5
Stop threads synchronously
andrykonchin Jul 17, 2026
6b70ea3
Refactor and simplify adapter/polling_spec.rb test because now stoppi…
andrykonchin Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/listen/adapter/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def stop
private

def _stop
@run_thread&.kill
@run_thread.kill.join if @run_thread

@houndci-bot houndci-bot Jul 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/SafeNavigation: Use safe navigation (&.) instead of checking if an object exists before calling the method.

@run_thread = nil
end

Expand Down
2 changes: 1 addition & 1 deletion lib/listen/adapter/darwin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def _process_event(dir, path)
end

def _stop
@worker_thread&.kill
@worker_thread.kill.join if @worker_thread

@houndci-bot houndci-bot Jul 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/SafeNavigation: Use safe navigation (&.) instead of checking if an object exists before calling the method.

super
end
end
Expand Down
3 changes: 1 addition & 2 deletions spec/lib/listen/adapter/polling_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,8 @@
expect(snapshot).to receive(:invalidate).
with(:dir, '.', { recursive: true })

t = Thread.new { subject.start }
subject.start
sleep 0.25
t.kill
end
end

Expand Down