Repository navigation
fix: preserve macOS short-command output and release v0.18.2 - #337
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS can flush unread master data when the final PTY slave closes. A fast Zsh command could write and close both streams before the relay observed handover; closing the recorder’s copies then silently lost stdout/stderr. This blocked v0.18.1 Release run 38777593503; no installers were published, and that annotated tag is retained.
Keep the recorder’s slave copies through command completion, drain queued bytes, then close them and continue to real EOF. Retired intervals still avoid recreating evidence, suspended/background writers keep their forwarding path, and EOF/EIO guards remain. Add a deterministic native-PTY regression (RED: empty stdout; GREEN: exact stdout/stderr and byte counts), and include macOS unit/build in PR CI so this platform behavior is checked before tagging.
Prepare v0.18.2 package metadata, download links and release notes with the same installed-only NSIS/DEB/DMG policy from #336. No tag is rewritten.
Validation: all five ordered local gates and production build PASS; 3,612 tests PASS / 24 explicit SKIP. Focused native regression/capture/degradation/transparency: 52 PASS. Final 100-command run retained every expected body/status (48,698ms total, mean 483ms including the driver settle). These local results do not stand in for the pending exact-head macOS/Windows/Linux CI and installer checks. Original release failure logs are preserved. Native WSL, full manual Kali/first-install stopwatch, and Mac quarantine/Dock/Developer ID/notarization remain explicit limitations; no spec is promoted to Verified.
The user has explicitly authorized merge and release; merge only after required checks for this head pass, then publish a new v0.18.2 tag and verify actual downloaded assets.