Split test-utils fixture.ts into focused modules#56
Merged
gtbuchanan merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
Break up the ~374-line fixture.ts whose responsibilities had drifted (command execution, git env isolation, version pinning, tarball matching, workspace discovery, and two fixture constructors) into focused modules: - lib/command.ts — CommandResult, runCommand, exec, createGitEnv - lib/workspace.ts — PackageJson schema, workspace root/index memo, resolveWorkspaceDeps - lib/tarball.ts — matchTarball, pinned, tarball memo, resolveTarballs - isolated-fixture.ts — createIsolatedFixture + types - project-fixture.ts — createProjectFixture, extendWithFixture + types - fixture.ts — thin barrel re-exporting the public surface Public API and behavior unchanged. Memo caches split cleanly: workspace root/index live in workspace.ts, tarball cache in tarball.ts — no cross-module state. Closes #55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/test-utils/src/fixture.tsinto focused modules:lib/command.ts,lib/workspace.ts,lib/tarball.ts,isolated-fixture.ts,project-fixture.ts, withfixture.tsas a thin barrel.createIsolatedFixture,createProjectFixture,extendWithFixture,pinned,matchTarball,createGitEnv,runCommand+ types).workspace.ts, tarball cache intarball.ts. No cross-module state.Closes #55.
Test plan
pnpm check(typecheck + lint + fast vitest across all packages)pnpm turbo run test:vitest:e2e(all 16 e2e tasks pass, including consumer packages that import from@gtbuchanan/test-utils)