Repository navigation
feat: button sizes from one data table (Feature #387) - #1165
Merged
Merged
Conversation
Six steps, xs 20, sm 24, md 28, lg 32, touch 44 and xl 52 px, each with its horizontal padding, icon size, icon-label gap, font size and radius. public/button-sizes.js exports the rows for tests and the token block in public/style.css carries them as --wv-btn-<step>-*; a test keeps the two in agreement. DESIGN.md gains a Buttons section. - .btn is the lg step and .btn-sm the md step: Tabler's own button variables read the step, so a .btn's height comes from --wv-btn-h and not from its padding. .wv-btn-* classes size every other button, and .wv-btn-square makes an icon-only button square at its step. - Header and toolbar icon buttons are all md, 28 px with a 16 px glyph, Copy permalink and the table's Set icon button included (Issue #1865). The sidebar toggle and the bug button are md, a section's eye and menu and the date picker sm, the column menu and New field xs. - Phone header and toolbar buttons switch to the touch step and the phone search bar, New and next-state buttons take xl; no phone rule writes a pixel size of its own. - The applet's bug face draws the md step's 28 px. - A date column's floor adds 2 px over the measured probe, which WebKit's input text needs at the wider date-button box. - test/button-sizes.test.mjs ratchets raw padding, height, min-height and width on button selectors: 75 to 31 in test/button-baseline.json. - test/button-sizes-browser.test.mjs walks the home, a table, the View panel, a docked record and a record page at 1440 and 390 px and fails on a visible button that matches no row; 26 entries across eight kinds of button are held in test/button-held.json under Issue #1880. ponytail: - The sweep reads five screens on the default seed. Upgrade path: walk the state catalog's overlays and the board, and lower the held list as Issue #1880 moves each kind onto a step. Change-Id: Ia3e6bb6d9807ecae7a4d521349bfdce74bd2d3f6
grunion-ai
enabled auto-merge (squash)
November 21, 2026 01:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracker: Feature #387 (https://weave.grunion.ai/w/weave/e/6204224c-f13d-431b-9fab-1e3b0f49a1e7). Fixes Issue #1865. Part of Issue #1864. New Issue #1880 holds the buttons still off the table.
What changed
public/button-sizes.jsexports the rows; the token block instyle.csscarries them as--wv-btn-<step>-*, andtest/button-sizes.test.mjskeeps the two in agreement. No build step..btnis lg and.btn-smis md through Tabler's own button variables (line height = step height less the border), so a Tabler button's height comes from its step..wv-btn-*classes size the rest;.wv-btn-squaremakes icon-only buttons square. The generic rule sits in:where()so the coarse-pointer 44 px hit floors still win on a phone.Gates
test/button-baseline.json.test/button-sizes-browser.test.mjswalks home, table, View panel, docked record and record page at 1440 and 390 px and fails on a visible button whose height and horizontal padding match no row. On main 56 distinct button shapes were seen and most missed the table; now 26 entries across eight kinds of button remain, all held intest/button-held.jsonunder Issue #1880 (sidebar section toggle and search, rail tiles, the grid's add row, View panel rows, phone launcher, phone doc permalink).Tests
render-budget type-doc|phone, which fails the same way on main locally and runs on the trend lane.