Skip to content

feat: button sizes from one data table (Feature #387) - #1165

Merged
grunion-ai merged 1 commit into
mainfrom
claude/button-sizes-1795219555
Nov 21, 2026
Merged

grunion-ai merged 1 commit into
mainfrom
claude/button-sizes-1795219555

Conversation

@grunion-ai

Copy link
Copy Markdown
Owner

Tracker: Feature #387 (https://weave.grunion.ai/w/weave/e/6204224c-f13d-431b-9fab-1e3b0f49a1e7). Fixes Issue #1865. Part of Issue #1864. New Issue #1880 holds the buttons still off the table.

What changed

Step Height Padding Icon Gap Font Radius
xs 20 8 16 4 12 control
sm 24 8 16 4 12 control
md 28 8 16 4 12 control
lg 32 12 16 8 14 control
touch 44 16 20 8 16 pill
xl 52 16 20 8 16 pill
  • public/button-sizes.js exports the rows; the token block in style.css carries them as --wv-btn-<step>-*, and test/button-sizes.test.mjs keeps the two in agreement. No build step.
  • .btn is lg and .btn-sm is md through Tabler's own button variables (line height = step height less the border), so a Tabler button's height comes from its step. .wv-btn-* classes size the rest; .wv-btn-square makes icon-only buttons square. The generic rule sits in :where() so the coarse-pointer 44 px hit floors still win on a phone.
  • Issue #1865: every icon button in both header rows is now md, 28 px with a 16 px glyph, Copy permalink and Set icon included (were 24 px and 12 or 16 px glyphs).
  • Sidebar toggle and bug button md (bug 26 to 28; the applet face follows), section eye/menu and date picker sm, column menu, New field and sidebar row menus xs, phone header buttons touch, phone search, New and next-state buttons xl. Raw sizes on those selectors are gone.
  • DESIGN.md gains a Buttons section; DEVELOPMENT.md lists the two ledgers; AGENTS.md maps the new public file.

Gates

  • Source: raw padding, height, min-height and width on button selectors, 75 on main to 31, ratcheted in test/button-baseline.json.
  • Browser: test/button-sizes-browser.test.mjs walks home, table, View panel, docked record and record page at 1440 and 390 px and fails on a visible button whose height and horizontal padding match no row. On main 56 distinct button shapes were seen and most missed the table; now 26 entries across eight kinds of button remain, all held in test/button-held.json under Issue #1880 (sidebar section toggle and search, rail tiles, the grid's add row, View panel rows, phone launcher, phone doc permalink).

Tests

  • Full inventory targeted locally (unit and browser): green except render-budget type-doc|phone, which fails the same way on main locally and runs on the trend lane.
  • Suites that pinned the old sizes now read the steps: header toolbar (copy 24 to 28), phone header pins (copy 22 to 28), record bar, bug button (26 to 28), dock crumb (one line measured against its tallest button), icon vocabulary (hidden phone icons do not draw).
  • Visual check at 1440 x 900: table header, docked record and View panel.

Six steps, xs 20, sm 24, md 28, lg 32, touch 44 and xl 52 px, each with
its horizontal padding, icon size, icon-label gap, font size and radius.
public/button-sizes.js exports the rows for tests and the token block in
public/style.css carries them as --wv-btn-<step>-*; a test keeps the two
in agreement. DESIGN.md gains a Buttons section.

- .btn is the lg step and .btn-sm the md step: Tabler's own button
  variables read the step, so a .btn's height comes from --wv-btn-h and
  not from its padding. .wv-btn-* classes size every other button, and
  .wv-btn-square makes an icon-only button square at its step.
- Header and toolbar icon buttons are all md, 28 px with a 16 px glyph,
  Copy permalink and the table's Set icon button included (Issue #1865).
  The sidebar toggle and the bug button are md, a section's eye and
  menu and the date picker sm, the column menu and New field xs.
- Phone header and toolbar buttons switch to the touch step and the
  phone search bar, New and next-state buttons take xl; no phone rule
  writes a pixel size of its own.
- The applet's bug face draws the md step's 28 px.
- A date column's floor adds 2 px over the measured probe, which WebKit's
  input text needs at the wider date-button box.
- test/button-sizes.test.mjs ratchets raw padding, height, min-height
  and width on button selectors: 75 to 31 in test/button-baseline.json.
- test/button-sizes-browser.test.mjs walks the home, a table, the View
  panel, a docked record and a record page at 1440 and 390 px and fails
  on a visible button that matches no row; 26 entries across eight kinds
  of button are held in test/button-held.json under Issue #1880.

ponytail:
- The sweep reads five screens on the default seed. Upgrade path: walk
  the state catalog's overlays and the board, and lower the held list
  as Issue #1880 moves each kind onto a step.

Change-Id: Ia3e6bb6d9807ecae7a4d521349bfdce74bd2d3f6
@grunion-ai
grunion-ai enabled auto-merge (squash) November 21, 2026 01:44
@grunion-ai
grunion-ai merged commit 23eda6a into main Nov 21, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant